refactor(pgpm): split the dials sources into @pgpmjs/import and @pgpmjs/diff; engine glue moves to @pgpmjs/transform - #1573
Merged
Conversation
…iff; move shared pipeline glue into @pgpmjs/transform
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pgpmjs/exporthad become the accidental home of the whole source-agnostic dials pipeline (#1569, #1571, #1572). This splits it back into one-package-per-front-door, with the shared engine glue in@pgpmjs/transform:transformgains a@pgpmjs/astdep (PgpmRow,parsePlanFile,readScript) instead of the old@pgpmjs/coreimports — core depends on transform, so the moved files now sit below core in the graph.restructureExportRows,partitionExportRows,parsePartitionConfig,loadModuleSource,snapshotCatalog/diffCatalogSnapshotsare all re-exported from@pgpmjs/transform.@pgpmjs/importand@pgpmjs/diffare pure leaves overast+naming-spec+transform; export is no longer in their dependency path.commands/{import,diff,transform,export}.tsjust import from the new homes;pgpm/cliadds@pgpmjs/import+@pgpmjs/diffdeps.module-source.test.ts→ transform,dump-source/import-rows→ import,diff-source→ diff). No test logic changed.Pre-existing (verified identical on clean
main): 7 failures inpgpm/exportmeta-config tests (routing_publicvsconstructive_routing_publicnaming) are unrelated to this move.Refs: constructive-planning#1340, constructive-planning#1329; follows #1569/#1571/#1572.
Link to Devin session: https://app.devin.ai/sessions/98edd75e27db4328aec77c581e211092
Requested by: @pyramation